Re: New backend: UMAX 1220P sane'ification take 1

From: stef (stef-listes@wanadoo.fr)
Date: Mon Apr 30 2001 - 22:40:39 PDT


> Fine. Please check backends/Makefile.in and tools/Makefile.in, there
> are some old names left. Also check if you want to rename
> tools/umax1220p.c to umax_pp.c. tools/Makefile.in: umax1220p isn't
> PHONY because that's an existing file.
>

        - done

> > - all debug and trace messages use DBG()
>
> In umax_pp_low.c there are some perrors and exit(-1). This will

        - removed

> definitely break other backends because it stops execution of the
> frontend. I didn't look to closely but if you use DBG in your 3 .c
> files you must set BACKEND_NAME and run DBG_INIT (only once!) in every
> one.

        - all files have their DBG_INIT, but only the backend has BACKEND_NAME
                defined. Makefile automatically provide the -DBACKEND_NAME=xxxx
                to the other files so I didn't redefined them. Should I remove
                the define from the backend, or add it to all files ?

>
> Check umax_pp_low.c: void sanei_umax_pp_InitPort (int port), there is
> a problem in the varaible section. mode must be defined even without
> HAVE_LINUX_PPDEV_H and parport_name needn't.

        - corrected
>
> Bye,
> Henning
>

        Will do a new version when I'll know what to do with BACKEND_NAME.

Regards,
        Stef

--
Source code, list archive, and docs: http://www.mostang.com/sane/
To unsubscribe: echo unsubscribe sane-devel | mail majordomo@mostang.com



This archive was generated by hypermail 2b29 : Mon Apr 30 2001 - 22:29:20 PDT