Re: New backend: UMAX 1220P sane'ification take 1

From: Henning Meier-Geinitz (henning@meier-geinitz.de)
Date: Mon Apr 30 2001 - 12:10:43 PDT

  • Next message: B Patston: "RE: : trust imagery 1200 wont work with xscanimage "no sane device""

    Hi,

    On Mon, Apr 30, 2001 at 07:30:12AM +0200, stef wrote:
    > I've updated the UMAX Astra 1220/1600/2000P backend so that it could be
    > included in SANE:
    >
    > - files have been renamed to umax_pp_low.[ch], umax_pp_mid.[ch]
    > and umax_pp.[ch] to avoid confusion with UMAX SCSI backend

    Fine. Please check backends/Makefile.in and tools/Makefile.in, there
    are some old names left. Also check if you want to rename
    tools/umax1220p.c to umax_pp.c. tools/Makefile.in: umax1220p isn't
    PHONY because that's an existing file.

    > - all debug and trace messages use DBG()

    In umax_pp_low.c there are some perrors and exit(-1). This will
    definitely break other backends because it stops execution of the
    frontend. I didn't look to closely but if you use DBG in your 3 .c
    files you must set BACKEND_NAME and run DBG_INIT (only once!) in every
    one.

    Check umax_pp_low.c: void sanei_umax_pp_InitPort (int port), there is
    a problem in the varaible section. mode must be defined even without
    HAVE_LINUX_PPDEV_H and parport_name needn't.

    Bye,
      Henning

    --
    Source code, list archive, and docs: http://www.mostang.com/sane/
    To unsubscribe: echo unsubscribe sane-devel | mail majordomo@mostang.com
    



    This archive was generated by hypermail 2b29 : Mon Apr 30 2001 - 12:04:36 PDT