Re: Patches for saned/net/scanimage/user-authorization....

From: Jochen Eisinger (jochen.eisinger@gno.de)
Date: Sat Nov 18 2000 - 12:20:55 PST

  • Next message: Henning Meier-Geinitz: "Re: xscanimage"

    Hi!

    [Henning Meier-Geinitz]
    > For Irix, the man page says index is in string.h. But that's untrue.
    > The compiler doesn't find a prototype and uses a return type of int.
    > Thtat's the source of the error (you can't do (int) - (char *). Took
    > me some time to find out :-)
    > Changing string.h to strings.h in sanei_auth.c, saned.c and scanimage.c
    > works.

    Could you please send me the patches? I wasn't aware of this...

    > index() is also used in mustek_pp (maybe others) so we should look a bit
    > more at this. You don't seem to use pointer arithmetics (or in a
    > different way) in mustek_pp so probably this is why the compilers
    > don't bail out there.

    Yes, I like this function a lot :-)

    >
    > I think this small change is acceptable. Have anyone used authorization
    > at all until now?

    Yes, me ;-)

    > > lib/md5.c include/md5.h include/sane/sanei_auth.h sanei/sanei_auth.c:
    >
    > mhh, ugly k&r style C :-). Seems to work however.

    Ok, Ok, I'll use indent -gnu, although I really like k&r...

    > The output
    > [resource] user:
    > may be a bit confusing because the debug output uses a similar form.
    > Can we use a more detailed output like:
    > "Authentification required for resource %s. Enter username: "
    > "Enter password:"

    sounds good, I'll change this.

    -- jochen

    --
    Source code, list archive, and docs: http://www.mostang.com/sane/
    To unsubscribe: echo unsubscribe sane-devel | mail majordomo@mostang.com
    



    This archive was generated by hypermail 2b29 : Sat Nov 18 2000 - 12:11:13 PST