Re: Patches for saned/net/scanimage/user-authorization....

From: Henning Meier-Geinitz (hmg-ml@gmx.de)
Date: Sat Nov 18 2000 - 12:52:37 PST

  • Next message: Oliver Neukum: "reaction to a smaller buffer size"

    Hi,

    On Sat, Nov 18, 2000 at 09:20:55PM +0100, Jochen Eisinger wrote:
    > [Henning Meier-Geinitz]
    > > For Irix, the man page says index is in string.h. But that's untrue.
    > > The compiler doesn't find a prototype and uses a return type of int.
    > > Thtat's the source of the error (you can't do (int) - (char *). Took
    > > me some time to find out :-)
    > > Changing string.h to strings.h in sanei_auth.c, saned.c and scanimage.c
    > > works.
    >
    > Could you please send me the patches? I wasn't aware of this...

    Sorry, no patches. I just added an "s" to the #include <string.h> in
    these three files.

    We must find a way to check if index() is in string.h or strings.h in
    configure and add something like
    #ifdef HAVE_STRINGS_H
    # include <strings.h>
    #else
    # include <string.h>
    #endif /* HAVE_STRINGS_H */

    to the files using index(). Where are the autoconf experts :-)?

    > > > lib/md5.c include/md5.h include/sane/sanei_auth.h sanei/sanei_auth.c:
    > >
    > > mhh, ugly k&r style C :-). Seems to work however.
    >
    > Ok, Ok, I'll use indent -gnu, although I really like k&r...

    Actually I was talking about the function parameters in md5.c:

    void *
    md5_read_ctx (ctx, resbuf)
         const struct md5_ctx *ctx;
         void *resbuf;

    instead of

    void *
    md5_read_ctx (const struct md5_ctx *ctx, void *resbuf);

    But it doesn't really matter.

    Bye,
      Henning

    --
    Source code, list archive, and docs: http://www.mostang.com/sane/
    To unsubscribe: echo unsubscribe sane-devel | mail majordomo@mostang.com
    



    This archive was generated by hypermail 2b29 : Sat Nov 18 2000 - 12:36:53 PST