Re: Kernel 2.4.X and HP Scanjet 6300C

From: Douglas Gilbert (dgilbert@interlog.com)
Date: Mon Jul 02 2001 - 15:01:53 PDT

Next message: Oliver Neukum: "Announcing the first release of a new driver for HP53xx scanners"

Previous message: Yuri Dario: "Re: What's the status of sanei-thread?"
In reply to: Tim Waugh: "Re: Kernel 2.4.X and HP Scanjet 6300C"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Tim Waugh wrote:
>
> On Sun, Jun 24, 2001 at 12:28:19AM -0400, Douglas Gilbert wrote:
>
> > - if ( (req->sgdata.sg3.hdr.info && SG_INFO_CHECK != 0)
> > + if ( (req->sgdata.sg3.hdr.info & SG_INFO_CHECK != 0)
>
> Doug, didn't we agree that this needs more parentheses? As in:
>
> if ( ((req->sgdata.sg3.hdr.info & SG_INFO_CHECK) != 0)
>
> ? Otherwise, (SG_INFO_CHECK != 0) is what gets evaluated first, which
> doesn't seem right.

Tim,
Yes, you are correct. I just checked the released sane 1.0.5
code and it is correct (i.e. has the extra pair of parentheses).

Doug Gilbert

--
Source code, list archive, and docs: http://www.mostang.com/sane/
To unsubscribe: echo unsubscribe sane-devel | mail majordomo@mostang.com

Next message: Oliver Neukum: "Announcing the first release of a new driver for HP53xx scanners"
Previous message: Yuri Dario: "Re: What's the status of sanei-thread?"
In reply to: Tim Waugh: "Re: Kernel 2.4.X and HP Scanjet 6300C"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Mon Jul 02 2001 - 15:00:05 PDT