XSane parameters or buffer bug

From: Oliver Rauch (oliver.rauch@rauch-domain.de)
Date: Thu May 10 2001 - 09:18:44 PDT

  • Next message: mh: "Re:( XSane parameters or buffer bug"

    mh wrote:

    > I don't know whether one should call it a bug in XSane; at least it could be
    > easily solved by calling sane_get_parameters() after sane_start() has been
    > called. (Oliver?)

    XSane does call sane_get parameters after sane_start:

    xsane-preview.c (around line 1921):
    -----------------------------------------
      status = sane_start(dev);
      if (status != SANE_STATUS_GOOD)
      {
        snprintf(buf, sizeof(buf), "%s %s.", ERR_FAILED_START_SCANNER, XSANE_STRSTATUS(status));
        xsane_back_gtk_error(buf, TRUE);
        preview_scan_done(p);
        return;
      }
     
      status = sane_get_parameters(dev, &p->params);
    -----------------------------------------

    xsane-scan.c (around line 1571):
    -----------------------------------------
      status = sane_start(dev);
      DBG(DBG_info, "sane_start returned with status %s\n", XSANE_STRSTATUS(status));
     
      if ((status == SANE_STATUS_NO_DOCS) && (xsane.adf_page_counter>0)) /* ADF out of docs but not first page */
      {
        xsane_scan_done(status); /* ok, stop multi image scan */
        snprintf(buf, sizeof(buf), "%s %d", TEXT_ADF_PAGES_SCANNED, xsane.adf_page_counter);
        xsane_back_gtk_info(buf, FALSE);
        xsane.adf_page_counter = 0;
        return;
      }
      else if (status != SANE_STATUS_GOOD) /* error */
      {
        xsane_scan_done(status);
        snprintf(buf, sizeof(buf), "%s %s", ERR_FAILED_START_SCANNER, XSANE_STRSTATUS(status));
        xsane_back_gtk_error(buf, TRUE);
        xsane.adf_page_counter = 0;
        return;
      }

      status = sane_get_parameters(dev, &xsane.param);
    -----------------------------------------

    So if xsane gets wrong parameters it is the fault of the backend.

    I also do not see an error in the scanning routine.
    May be there could happen something in the transformation routines
    (jpeg/tiff/png/...).

    Bye
    Oliver

    -- 
    Homepage:	http://www.rauch-domain.de
    sane-umax:	http://www.rauch-domain.de/sane-umax
    xsane:		http://www.xsane.org
    E-Mail:		mailto:Oliver.Rauch@rauch-domain.de
    

    -- Source code, list archive, and docs: http://www.mostang.com/sane/ To unsubscribe: echo unsubscribe sane-devel | mail majordomo@mostang.com



    This archive was generated by hypermail 2b29 : Thu May 10 2001 - 09:24:28 PDT