Benjamin Hell wrote:
> Thanks for the patch, appears as if it works now,
> at least I can use the scanner and get some pictures!
> But there is still a small bug apparently introduced
> by the first patch in the sharp backend:
>
> gcc -I/usr/local/gimp/include -c -g -O2 -W -Wall -DSCSIBUFFERSIZE=131072
> -DHAVE_CONFIG_H -I. -I. -I../include -I../include -D_GNU_SOURCE
> -DPATH_SANE_CONFIG_DIR=/usr/local/etc/sane.d
> -DPATH_SANE_DATA_DIR=/usr/local/share -DV_MAJOR=1 -DV_MINOR=0
> -DBACKEND_NAME=sharp -DLIBDIR=/usr/local/lib/sane sharp.c -fPIC -DPIC -o
> .libs/sharp.lo
> sharp.c: In function ense_handler':
> sharp.c:385:
> X350' undeclared (first use in this function)
> sharp.c:385: (Each undeclared identifier is reported only once
> sharp.c:385: for each function it appears in.)
Uuhhh... This proves that I am not a good bureaucrat. I wrote the patch
to sanei_scsi.c in my "personal version" of the Sane package, which
contains version 0.31 of the Sharp backend. After finishing and testing
the patch (with a Sharp scanner...), I copied the files sanei_scsi.[ch],
canon-scsi.c (or which was it??) and sharp.c to a directory containing
the Sane sources version 1.0.2 (containing an older version of Sharp
backend), and let diff run against the unpatched 1.0.2 version.
Obviously, I forgot to copy sharp.h... That file should have an entry
'JX350' in the enum list together with JX330, JX250 and so on. I attach
another patch for sharp.h. (No, I'm not going to start a patch series
like the one for the Columbia Appletalk package with more tha 100 patch
files :) I'm only a little bit busy with other stuff right now.)
Anyway, its fine to hear that the patch now really works for Solaris,
and FreeBSD. Thanks to you, Benjamin and Ben, for testing and reporting!
I would really appreciate it, if other people could test the patch for
other Unixes. Of course it would be best, if the test is made with a
Canon scanner, but the patch affects _all_ SCSI commands sent to any
SCSI scanner. Therefore, a test with any SCSI scanner would help a lot.
Abel
--- ../../../sane-sharp-0.31/backend/sharp.h Mon Mar 6 08:57:30 2000
+++ sharp.h Sun Mar 5 14:42:39 2000
@@ -160,13 +160,12 @@
typedef enum
{
- /* JX250, JX330, JX350, JX610 are used as array indices, so the
- corresponding numbers should start at 0
+ /* JX250, JX330, JX610 are used as array indices, so the corresponding
+ numbers should start at 0
*/
unknown = -1,
JX250,
JX330,
- JX350,
JX610
}
SHARP_Model;
-- Source code, list archive, and docs: http://www.mostang.com/sane/ To unsubscribe: echo unsubscribe sane-devel | mail majordomo@mostang.com
This archive was generated by hypermail 2b29 : Sun Jun 11 2000 - 07:42:59 PDT