scanimage and 3-pass scanners

From: Henning Meier-Geinitz (hmg-ml@gmx.de)
Date: Sat Apr 01 2000 - 02:27:52 PST

  • Next message: Michael Krause: "Re: HP3300, documentation about non-SCL-scanners"

    Hi,

    I just tried to use scanimage to scan in color mode with a 3-pass scanner
    (Mustek MFS-12000CX). It doesn't work, the scan is cancelled immediately
    after the start of the first frame (sane_cancel is called).

    I think I found an error in scanimage.c. Look at the following code snippet
    in scan_it ():

                  if (!advance (&image))
                    status = SANE_STATUS_NO_MEM;
                    goto cleanup;

    It's a check if the realloc in advance() succeded. I think the author of the
    program missed the {} around the two commands (as the indentation suggests).
    "goto cleanup" is called even if no error occured so the scan is stopped
    allways. Proposed correction:

                  if (!advance (&image))
                    {
                      status = SANE_STATUS_NO_MEM;
                      goto cleanup;
                    }
                    
    This snipped is used three more times in the code. If I change all of them
    the scan is successful.

    This should concern everyone using a 3-pass scanner and color mode.

    Could somebody with more knowledge in the frontends look into it and fix it
    if I am correct?

    Ciao, Henning 

    --
Source code, list archive, and docs: http://www.mostang.com/sane/
To unsubscribe: echo unsubscribe sane-devel | mail majordomo@mostang.com

    This archive was generated by hypermail 2b29 : Sat Apr 01 2000 - 02:33:19 PST