Re: bug in sanei_debug.h

• Previous message: Petter Reinholdtsen: "Re: Patches for sanei_debug.h/sanei_init_debug.c and the HP-backend"
• Maybe in reply to: Jochen Eisinger: "bug in sanei_debug.h"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

[Jochen Eisinger]
> No, my backend (mustek_pp) uses some gcc-extensions :) they are soo
> nice, I just had to use them... I'm using __PRETTY_FUNCTION__ to let
> ASSERT() know from where it is called - do you think I should remove
> it?

Hm, idealy, yes. It is a lot easier to maintain and test source with
as few #if tests in the source as possible. SANE should compile on
any ANSI C compiler, and using GNU C extentions means more #if tests
to make sure it still compiles on non GNU compilers.

On the other hand, I know __PRETTY_FUNCTION__ is very nice.

But if the code isn't broken, you don't need to fix it. It is your
(ie. the backend maintainer) pain to make sure this code compiles on
all ANSI C compilers, not mine.

-- 
##>  Petter Reinholdtsen  <##  |  pere@td.org.uit.no
--
Source code, list archive, and docs: http://www.mostang.com/sane/
To unsubscribe: echo unsubscribe sane-devel | mail majordomo@mostang.com

• Next message: Petter Reinholdtsen: "Re: Strange problem regarding remote scanning"
• Previous message: Petter Reinholdtsen: "Re: Patches for sanei_debug.h/sanei_init_debug.c and the HP-backend"
• Maybe in reply to: Jochen Eisinger: "bug in sanei_debug.h"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Oct 22 2000 - 19:31:02 PDT