Patch to sanei_debug.h

From: Peter Kirchgessner (peter@kirchgessner.net)
Date: Sun Jan 30 2000 - 05:20:58 PST

  • Next message: Dave Hill: "Re: xsane-0.52 available"

    Hi,

    when linking frontends, I get warnings like these:

    ../backend/.libs/libsane.a(hp-device.o): warning: multiple common of
    `sanei_debug_hp'
    ../backend/.libs/libsane.a(hp.o): warning: previous common is here

    This seems to be due to a definition in sanei_debug.h:

    #if defined(BACKEND_NAME) && !defined(STUBS)
    int PASTE(sanei_debug_,BACKEND_NAME);
    #endif

    When using the STUBS-macro, I get undeclared-errors for sanei_debug_hp.
    I suggest a patch like the following should solve the problem:

    --- include/sane/sanei_debug.h.orig Mon Aug 9 20:05:43 1999
    +++ include/sane/sanei_debug.h Sun Jan 30 11:47:56 2000
    @@ -25,7 +25,10 @@

     #define DBG_LEVEL PASTE(sanei_debug_,BACKEND_NAME)

    -#if defined(BACKEND_NAME) && !defined(STUBS)
    +#if defined(BACKEND_NAME)
    +# ifdef STUBS
    +extern
    +# endif
     int PASTE(sanei_debug_,BACKEND_NAME);
     #endif

    I.E. a backend should have one module without STUBS defined, all others
    should use STUBS.

    Any comments ? If no comments, could someone place it in the CVS-tree ?

    Sincerely

    Peter 

    -- 
Peter Kirchgessner
WWW:    http://www.kirchgessner.net
e-mail: peter@kirchgessner.net

    --
Source code, list archive, and docs: http://www.mostang.com/sane/
To unsubscribe: echo unsubscribe sane-devel | mail majordomo@mostang.com

    This archive was generated by hypermail 2b29 : Sun Jan 30 2000 - 05:32:04 PST